Skip to content

Update MOI interface#27

Merged
klamike merged 20 commits into
mainfrom
mk/moi2
Mar 7, 2026
Merged

Update MOI interface#27
klamike merged 20 commits into
mainfrom
mk/moi2

Conversation

@klamike
Copy link
Copy Markdown
Collaborator

@klamike klamike commented Feb 28, 2026

@blegat thanks for your suggestions in #25, would super appreciate your review here.

  • Implements default_cache with UniversalFallback (I was getting some error with MOI.Silent otherwise)
  • Renames to src/MOI_wrapper.jl
  • Adds "Use with JuMP" section to README
  • Adds environment variable to control when to run MOI test suite

closes #25

@klamike klamike requested a review from gdalle February 28, 2026 18:05
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Comment thread src/MOI_wrapper.jl Outdated
Comment thread README.md
Copy link
Copy Markdown
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert on MOI bindings so I have a few surface comments but I'll let @blegat validate the rest if he has time (otherwise I trust @klamike's judgement)

Comment thread README.md Outdated
Comment thread test/runtests.jl Outdated
@gdalle
Copy link
Copy Markdown
Member

gdalle commented Mar 5, 2026

I just realized we don't need a separate workflow file for the MOI tests. We can get away with a strategy matrix that sets the environment variable (check out how I did it in DifferentiationInterface)

@klamike
Copy link
Copy Markdown
Collaborator Author

klamike commented Mar 6, 2026

@blegat looking good now?

Copy link
Copy Markdown

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@klamike
Copy link
Copy Markdown
Collaborator Author

klamike commented Mar 7, 2026

@gdalle is this how you wanted the CI set up?

@gdalle
Copy link
Copy Markdown
Member

gdalle commented Mar 7, 2026

Yes, perfect, this will speed things up a bit by parallelizing

@klamike klamike merged commit e5cc1cd into main Mar 7, 2026
7 checks passed
@gdalle gdalle deleted the mk/moi2 branch March 9, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve MOI bindings

3 participants