Fix duplicate elseif condition in interpret_repo_and_remotes#2928
Open
singhharsh1708 wants to merge 2 commits into
Open
Fix duplicate elseif condition in interpret_repo_and_remotes#2928singhharsh1708 wants to merge 2 commits into
singhharsh1708 wants to merge 2 commits into
Conversation
added 2 commits
April 26, 2026 15:06
The second elseif branch had the same condition as the first (startswith(makedocs_root_remoteref.root, makedocs_root_repo)), but its comment described the opposite case: the git repo root being more specific (nested deeper) than the remotes path. Fix it to use startswith(makedocs_root_repo, makedocs_root_remoteref.root). Fixes JuliaDocs#2868
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second elseif branch had the same condition as the first (startswith(makedocs_root_remoteref.root, makedocs_root_repo)), but its comment described the opposite case: the git repo root being more specific (nested deeper) than the remotes path. Fix it to use startswith(makedocs_root_repo, makedocs_root_remoteref.root). Fixes #2868