Skip to content

Remove GroupSlices module#447

Merged
Datseris merged 2 commits into
mainfrom
fix_hash_args
Apr 30, 2026
Merged

Remove GroupSlices module#447
Datseris merged 2 commits into
mainfrom
fix_hash_args

Conversation

@kahaaga
Copy link
Copy Markdown
Member

@kahaaga kahaaga commented Apr 30, 2026

Fixes the same issue as #https://github.com/JuliaDynamics/Associations.jl/pull/403, by entirely deleting the GroupSlices module where the hash method was implemented. The module is no longer used.

@Datseris
Copy link
Copy Markdown
Member

Datseris commented Apr 30, 2026

Is this compatible with the PR we just merged, #434 ? I thought this was used there.

@kahaaga
Copy link
Copy Markdown
Member Author

kahaaga commented Apr 30, 2026

Is this compatible with the PR we just merged, #434 ? I thought this was used there.

As far as I can tell, after #434 we only use the inds_in_terms_of_unique methods in the probabilities_estimators/utils.jl file for the transfer operator. So should be good. There's no code that I can find that depends on any of the groupslices methods any longer.

@Datseris Datseris merged commit a508bf7 into main Apr 30, 2026
2 checks passed
@Datseris Datseris deleted the fix_hash_args branch April 30, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Datseris Datseris Datseris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kahaaga @Datseris