Export referenced_sciml_prob with correct spelling#236
Closed
reykboerner wants to merge 1 commit into
Closed
Conversation
Datseris
requested changes
Oct 1, 2025
Datseris
left a comment
Datseris
left a comment
Member
There was a problem hiding this comment.
- Version bump is missing
- Correct spelling should be the spelling used everywhere with a mass replace. The wrong spelling should be the deprecation and it should be in the file deprecated.jl at top-level (if it doens't exist we make one now).
| """ | ||
| referrenced_sciml_prob(ds::Dynamical system) | ||
|
|
||
| Return `ds.integ.sol.prob` if there is a referenced model. |
Member
There was a problem hiding this comment.
You should say what it returns instead of the field that it returns. Internal fields are not public.
| # Simply extend the `referrenced_sciml_prob` and you have symbolic indexing support! | ||
| import SymbolicIndexingInterface | ||
| """ | ||
| referrenced_sciml_prob(ds::Dynamical system) |
Member
There was a problem hiding this comment.
Suggested change
| referrenced_sciml_prob(ds::Dynamical system) | |
| referrenced_sciml_prob(ds::DynamicalSystem) |
Member
|
@reykboerner bump |
Member
|
@reykboerner Shall I finish this? |
Contributor
Author
|
Sure, would be great @oameye |
Datseris
pushed a commit
that referenced
this pull request
May 15, 2026
Finishes #236 by following the maintainer's review: - Mass-replace the misspelled `referrenced` with `referenced` across src, tests, docs and CHANGELOG, including comments and error messages. - Export `referenced_sciml_prob` (previously unexported despite being part of the public extension API) and add a docstring. - Keep `referrenced_sciml_prob`, `referrenced_sciml_model` and the internal `has_referrenced_model` as deprecated aliases in `src/deprecations.jl`, so downstream code keeps working with a deprecation warning. - Bump version to 3.18.0 and add a changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using
referrenced_sciml_probdownstream but it is currently neither exported nor declared public. Also, it would be nice to switch to a correct spelling ofreferenced. Maybe this can be solved with an alias for now and then the old spelling can become deprecated in the future?