Rename referrenced -> referenced, deprecate old spellings#257
Merged
Datseris merged 1 commit intoMay 15, 2026
Merged
Conversation
Finishes JuliaDynamics#236 by following the maintainer's review: - Mass-replace the misspelled `referrenced` with `referenced` across src, tests, docs and CHANGELOG, including comments and error messages. - Export `referenced_sciml_prob` (previously unexported despite being part of the public extension API) and add a docstring. - Keep `referrenced_sciml_prob`, `referrenced_sciml_model` and the internal `has_referrenced_model` as deprecated aliases in `src/deprecations.jl`, so downstream code keeps working with a deprecation warning. - Bump version to 3.18.0 and add a changelog entry.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 82.00% 83.50% +1.49%
==========================================
Files 15 15
Lines 717 970 +253
==========================================
+ Hits 588 810 +222
- Misses 129 160 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datseris
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes #236, applying @Datseris's review feedback.
referrenced->referencedacross src, tests, docs and CHANGELOG, including comments and error messages (also fixes the typosreferrencing,referrence).referenced_sciml_prob(previously unexported) and give it a docstring.src/deprecations.jlfor the misspelled names so downstream code keeps working with a deprecation warning:referrenced_sciml_prob->referenced_sciml_probreferrenced_sciml_model->referenced_sciml_modelhas_referrenced_model->has_referenced_model(non-exported form)Closes #236.