Skip to content

make logging safe again#146

Merged
Krastanov merged 2 commits into
JuliaDynamics:masterfrom
vtjnash:jn/log-safe
Jan 14, 2026
Merged

make logging safe again#146
Krastanov merged 2 commits into
JuliaDynamics:masterfrom
vtjnash:jn/log-safe

Conversation

@vtjnash

@vtjnash vtjnash commented Jan 13, 2026

Copy link
Copy Markdown
Collaborator

Re-sync this with GPUCompiler to pick up required changes for v1.11+

Re-sync this with GPUCompiler to pick up required changes for v1.11+
@vtjnash

vtjnash commented Jan 13, 2026

Copy link
Copy Markdown
Collaborator Author

Note the tests that are failing on this PR were intentionally broken yesterday in a breaking change to ExplicitImports.jl. Since there doesn't seem to be a workaround, maybe just delete that package dependency from here? JuliaTesting/ExplicitImports.jl#159 (comment)

@Krastanov

Copy link
Copy Markdown
Member

Thanks, Jameson! Marking the test as broken should be good enough on my end, no point in spending time figuring out workarounds. I should be able to look into this next week.

@codecov-commenter

codecov-commenter commented Jan 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.55%. Comparing base (a33b31a) to head (581c9bf).

Files with missing lines Patch % Lines
src/safe_logging.jl 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   80.14%   79.55%   -0.59%     
==========================================
  Files           6        6              
  Lines         675      680       +5     
==========================================
  Hits          541      541              
- Misses        134      139       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov Krastanov merged commit b230aef into JuliaDynamics:master Jan 14, 2026
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants