Draft: narrow JuliaLowering generator/filter seam for #99#157
Draft: narrow JuliaLowering generator/filter seam for #99#157dtopenclaw wants to merge 33 commits into
Conversation
|
Quick follow-up on the benchmark check for this draft PR:
~/.juliaup/bin/julia --project=benchmark -e 'using Pkg; Pkg.instantiate()'
~/.juliaup/bin/julia --project=benchmark benchmark/benchmarks.jlThat local run completed with exit code So at least from this pass, the red benchmark check does not appear to be a straightforward local benchmark-script failure introduced by the branch itself. |
|
One more CI note on the
Given that:
this looks increasingly like a workflow/action-side problem (or at least not a simple reproducible local branch regression from the benchmark script alone). |
|
I dug one level deeper on the red benchmark check and now have a more concrete local reproduction. The key difference is that the GitHub workflow is not just running I reproduced that path locally with: benchpkg ResumableFunctions \
--url=https://github.com/JuliaDynamics/ResumableFunctions.jl \
--output-dir=results-ci-repro \
--rev=master,f0431e1c78bd223c29e8fbc11f20ef824567981a \
--bench-on=masterThat local preceded by: By contrast, directly running the benchmark script on this branch still passes locally after instantiating the benchmark environment. So the current strongest explanation is:
I wrote the full local note to |
|
I pushed the benchmark investigation one step further and found a likely code-level compatibility fix candidate for the ASV wrapper failure. The current using ..Main: S_hc, rng, VThat seems fine when the script is run directly from I tested a local patch candidate that replaces the const S_hc = $(S_hc)
const rng = $(rng)
const V = $(V)Then I ran an ASV-style wrapper include locally from a temp copy of the repo: julia --project=benchmark -e 'using Pkg; Pkg.instantiate(); module AirspeedVelocityRunner; include("benchmark/benchmarks.jl"); end; println("INCLUDE_OK")'That completed with exit code Caveat: I have not fully proven that this alone would make the current GitHub benchmark check go green, because local I wrote the fuller local note to: |
|
One more validation datapoint on the suspected ASV wrapper fix candidate. I re-ran the candidate patch in a temp copy of the repo and validated both of these paths successfully:
~/.juliaup/bin/julia --project=benchmark benchmark/benchmarks.jl
~/.juliaup/bin/julia --project=benchmark -e 'using Pkg; Pkg.instantiate(); module AirspeedVelocityRunner; include("benchmark/benchmarks.jl"); end; println("INCLUDE_OK")'The candidate patch was the same minimal change inside the generated benchmark modules: # before
using ..Main: S_hc, rng, V
# candidate
const S_hc = $(S_hc)
const rng = $(rng)
const V = $(V)Results from the patched temp copy:
So the candidate appears to preserve the ordinary benchmark execution path while also fixing the wrapper-loaded module path that was failing under the ASV runner assumption. I saved the combined validation output here: I also generated a minimal patch artifact here: Still with the same caveat as before: because the benchmark action compares against the default-branch side as well, the current GitHub check may still need the baseline script path (or benchmark workflow logic) to reflect the fix before the red check can actually clear. |
|
closing as AI slop |
This draft PR packages a very narrow first JuliaLowering-facing slice for #99.
Scope
What is included
Base.show_unquotedfor Expr source)Key files
src/macro.jlsrc/utils.jltest/test_main.jlexamples/experimental_julialowering_seam_readiness.jlreports/resumablefunctions-99-maintainer-handoff-2026-03-23.mdreports/patches/resumablefunctions-99-2026-03-23/README.mdValidation
~/.juliaup/bin/julia --project=. -e 'using Pkg; Pkg.test(test_args=["main"])'passes on Julia 1.11JuliaLowering, the representative smoke path reachesPOSTLOAD_CONTRACT_MET=true~/.juliaup/bin/julia --project=benchmark -e 'using Pkg; Pkg.instantiate()'~/.juliaup/bin/julia --project=benchmark benchmark/benchmarks.jlCI note
benchmarkcheck is currently red on this PRworkflow file may be brokenaction_requiredwith no jobs started from this account's viewWhy this PR exists
The issue discussion notes that a branch on which a JuliaLowering-based path succeeds can count as bounty completion even before merge readiness. This PR is meant to give maintainers a concrete review/delivery artifact for that narrow first slice rather than claiming the full migration is done.
Related to #99.