Fix JET name collisions in @resumable expansion#159
Merged
Krastanov merged 2 commits intoApr 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 80.86% 80.57% -0.30%
==========================================
Files 6 6
Lines 690 695 +5
==========================================
+ Hits 558 560 +2
- Misses 132 135 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@resumablecollision-resistant under JET/Revise replayRoot cause
JET.report_packagereplays top-level definitions through Revise/JuliaInterpreter. In that path, plaingensym()-derived top-level bindings from separate@resumableexpansions can collide, which makes different helper methods and generated types share the same name.That is why
only(methods(inferfn, Tuple))started failing after PR #147: it was seeing multiple methods attached to a collided helper binding, not a genuine ambiguity in the resumable function being analyzed.Verification
Reproduced and fixed with a clean direct CLI run, outside the package test runner: