Preserve structured logging metadata in @resumable functions#165
Merged
Krastanov merged 2 commits intoJul 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 80.57% 81.29% +0.71%
==========================================
Files 6 6
Lines 695 727 +32
==========================================
+ Hits 560 591 +31
- Misses 135 136 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
force-archMotivation
Generic macro scoping currently rewrites both sides of structured logging metadata assignments. Inside an
@resumablefunction, fields such as_group,event, androundtherefore lose their stable logging names. This change scopes only metadata values while leaving the keys intact.The macOS x64 matrix job also began failing during
setup-juliaaftermacos-latestmoved to Apple Silicon. The addedforce-archinput is the action-prescribed setting for retaining that intentional x64 coverage.Validation
julia --project=. -e "using Pkg; Pkg.test()"on Julia 1.12.6julia +1.10 --project=. -e "using Pkg; Pkg.test()"on Julia 1.10.11julia --project=docs docs/make.jlgit diff --check