Skip to content

Preserve structured logging metadata in @resumable functions#165

Merged
Krastanov merged 2 commits into
JuliaDynamics:masterfrom
Krastanov-agent:fix-structured-logging-metadata-codex
Jul 17, 2026
Merged

Preserve structured logging metadata in @resumable functions#165
Krastanov merged 2 commits into
JuliaDynamics:masterfrom
Krastanov-agent:fix-structured-logging-metadata-codex

Conversation

@Krastanov-agent

@Krastanov-agent Krastanov-agent commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • recognize Julia standard logging macros during resumable-function scoping
  • preserve metadata keys while scoping their values, including shorthand fields
  • cover unqualified, qualified, and explicit-level logging forms
  • bump the package to v1.0.7 and add the release changelog entry
  • allow the intentional macOS x64 CI job to run on Apple Silicon runners via force-arch

Motivation

Generic macro scoping currently rewrites both sides of structured logging metadata assignments. Inside an @resumable function, fields such as _group, event, and round therefore lose their stable logging names. This change scopes only metadata values while leaving the keys intact.

The macOS x64 matrix job also began failing during setup-julia after macos-latest moved to Apple Silicon. The added force-arch input is the action-prescribed setting for retaining that intentional x64 coverage.

Validation

  • julia --project=. -e "using Pkg; Pkg.test()" on Julia 1.12.6
  • julia +1.10 --project=. -e "using Pkg; Pkg.test()" on Julia 1.10.11
  • focused logging tests: 14/14 on both Julia versions
  • julia --project=docs docs/make.jl
  • git diff --check

@codecov-commenter

codecov-commenter commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.29%. Comparing base (9676438) to head (ec958d5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   80.57%   81.29%   +0.71%     
==========================================
  Files           6        6              
  Lines         695      727      +32     
==========================================
+ Hits          560      591      +31     
- Misses        135      136       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov
Krastanov merged commit 11b5311 into JuliaDynamics:master Jul 17, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants