Require Optim.jl v2.0.1#75
Closed
juliohm wants to merge 4 commits into
Closed
Conversation
Member
Author
|
cc: @pkofod |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 77.76% 77.78% +0.01%
==========================================
Files 47 47
Lines 1390 1391 +1
==========================================
+ Hits 1081 1082 +1
Misses 309 309 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I see one test fails |
Member
Author
|
It is the same one that failed when we changed the linesearch method. Should I also remove the linesearch option and use the default? |
Member
Author
|
All tests are now passing in Julia LTS. For some unknown reason another unrelated test is failing on Julia latest stable release. I've restarted the tests to see if the error is gone. |
Member
Author
|
@pkofod I am now seeing errors like this: ┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/8pGuC/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/8pGuC/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/8pGuC/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/8pGuC/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/8pGuC/src/multivariate/optimize/optimize.jl:136
Fitting transiograms: Test Failed at /home/runner/work/GeoStatsFunctions.jl/GeoStatsFunctions.jl/test/fitting.jl:165
Expression: all(proportions(τ) .≤ ps) |
Member
Author
|
@pkofod any suggestion on how to proceed here? |
Member
Author
|
Closing in favor of #79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optim.jl v2.0.1 is still showing warnings about NaN gradients: