Skip to content

Require Optim.jl v2.0.1#75

Closed
juliohm wants to merge 4 commits into
mainfrom
optim-warning
Closed

Require Optim.jl v2.0.1#75
juliohm wants to merge 4 commits into
mainfrom
optim-warning

Conversation

@juliohm

@juliohm juliohm commented Feb 5, 2026

Copy link
Copy Markdown
Member

Optim.jl v2.0.1 is still showing warnings about NaN gradients:

Testing fitting.jl...
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/DtV5C/src/multivariate/optimize/optimize.jl:136

@juliohm

juliohm commented Feb 5, 2026

Copy link
Copy Markdown
Member Author

cc: @pkofod

@codecov-commenter

codecov-commenter commented Feb 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.78%. Comparing base (58426df) to head (e303bfd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   77.76%   77.78%   +0.01%     
==========================================
  Files          47       47              
  Lines        1390     1391       +1     
==========================================
+ Hits         1081     1082       +1     
  Misses        309      309              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkofod

pkofod commented Mar 24, 2026

Copy link
Copy Markdown

I see one test fails

@juliohm

juliohm commented Mar 24, 2026

Copy link
Copy Markdown
Member Author

It is the same one that failed when we changed the linesearch method. Should I also remove the linesearch option and use the default?

@juliohm

juliohm commented Mar 24, 2026

Copy link
Copy Markdown
Member Author

All tests are now passing in Julia LTS. For some unknown reason another unrelated test is failing on Julia latest stable release. I've restarted the tests to see if the error is gone.

@juliohm

juliohm commented Mar 24, 2026

Copy link
Copy Markdown
Member Author

@pkofod I am now seeing errors like this:

┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/8pGuC/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/8pGuC/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/8pGuC/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/8pGuC/src/multivariate/optimize/optimize.jl:136
┌ Warning: Terminated early due to NaN in gradient.
└ @ Optim ~/.julia/packages/Optim/8pGuC/src/multivariate/optimize/optimize.jl:136
Fitting transiograms: Test Failed at /home/runner/work/GeoStatsFunctions.jl/GeoStatsFunctions.jl/test/fitting.jl:165
  Expression: all(proportions(τ) .≤ ps)

@juliohm

juliohm commented Mar 31, 2026

Copy link
Copy Markdown
Member Author

@pkofod any suggestion on how to proceed here?

@juliohm

juliohm commented Apr 25, 2026

Copy link
Copy Markdown
Member Author

Closing in favor of #79

@juliohm juliohm closed this Apr 25, 2026
@juliohm juliohm deleted the optim-warning branch April 25, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants