Opting out of enforce_triplequote_docstring.#1204
Conversation
f87db42 to
9f843c3
Compare
9f843c3 to
2480938
Compare
penelopeysm
left a comment
penelopeysm
left a comment
There was a problem hiding this comment.
Thanks for looking into it!
|
Also, I'm sure you noticed this too but the argument needs to be added to the option(
"--enforce-triplequote-docstring";
...
), |
|
Thank you for feedback @penelopeysm. Ready for the next round :) |
a1d8303 to
bed39de
Compare
bed39de to
9293094
Compare
penelopeysm
left a comment
penelopeysm
left a comment
There was a problem hiding this comment.
This looks really good! I'll just run a regression test and if it doesn't make anything stupendously ugly we should be fine.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
ah darn I haven't made it use the cli app yet |
|
!formatbot JuliaLang/julia@v1.12.6 v2_stable_multiline_strings=true format_docstrings=true |
FormatBot Results
Error: Formatting with base failed. See workflow run. |
|
Okay, that's pretty annoying. Base Julia contains docstrings that contain invalid Julia code, so it can't format them. That's a separate error worth fixing, but I think I'll just trust the tests for now. Finally, just some bikeshedding: I might do a slight rename to |
|
Totally ok. Thank you for support <3 |
|
Fab! Thank you so much for taking this on! |
|
No worries. It did help a lot that you wrote which file to work on and that the changes would most likely be contained there :) What's the usual release schedule? |
|
Usually instantly, but there are a couple things I want to fix and bundle into a release, so hopefully later today. |
|
v2.11.0 is released now :) |
2 participants
Here is a first shot at addressing #1203 it @penelopeysm.
I am happy with it yet except that I don't understand why this (new) test is failing..?
It seems that it is failing due to something outside the strict
format_docstring()function, because this one does return the correct result IIUC.Maybe that leading whitespace is preventing the docstring to be recognized as such?