Skip to content

Commit 5f53814

Browse files
committed
fix benchmark result posting
1 parent 83c73c9 commit 5f53814

2 files changed

Lines changed: 26 additions & 3 deletions

File tree

.github/workflows/benchmark.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,17 @@
11
name: Benchmark
22
on:
33
- pull_request
4-
permissions:
5-
pull-requests: write # needed to post comments
4+
5+
# No special permissions needed — the action uploads an artifact
6+
# instead of commenting directly. A separate workflow_run workflow
7+
# (post_benchmark_comment.yml) picks up the artifact and posts the comment.
8+
69
jobs:
710
benchmark:
811
name: Benchmark
912
runs-on: ubuntu-latest
1013
steps:
11-
- uses: MilesCranmer/AirspeedVelocity.jl@action-v1
14+
- uses: hakkelt/AirspeedVelocity.jl@master
1215
with:
1316
julia-version: '1'
17+
post-comment: 'false'
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: Post Benchmark Comment
2+
3+
on:
4+
workflow_run:
5+
workflows: ["Benchmark"]
6+
types: [completed]
7+
8+
permissions:
9+
pull-requests: write
10+
11+
jobs:
12+
comment:
13+
if: github.event.workflow_run.conclusion == 'success'
14+
runs-on: ubuntu-latest
15+
steps:
16+
- uses: hakkelt/AirspeedVelocity.jl/post-comment@master
17+
with:
18+
run-id: ${{ github.event.workflow_run.id }}
19+
github-token: ${{ github.token }}

0 commit comments

Comments
 (0)