Keep Symmetric/Hermitian matmul with BLAS eltypes off BLAS.symm!/hemm!.#734
Merged
Conversation
GPU arrays are DenseArrays, so they match LinearAlgebra's
StridedMatrix{<:BlasFloat} generic_matmatmul_wrapper! methods for the
SymmHemmGeneric flags, which call BLAS.symm!/hemm! on device memory.
Route them to generic_matmatmul! like the existing SyrkHerkGemm
override, letting backends (or the generic kernel) handle the wrapper.
Also requires Adapt 4.6.1, which fixes uplo being dropped when adapting
Symmetric/Hermitian kernel arguments.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
oneAPI.jl failure is real; JuliaGPU/oneAPI.jl#577 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPU arrays are DenseArrays, so they match LinearAlgebra's
StridedMatrix{<:BlasFloat}generic_matmatmul_wrapper!methods for theSymmHemmGenericflags, which callBLAS.symm!/hemm!on device memory. Route them togeneric_matmatmul!like the existing SyrkHerkGemm override, letting backends (or the generic kernel) handle the wrapper.Also requires Adapt 4.6.1, which fixes uplo being dropped when adapting Symmetric/Hermitian kernel arguments.