Skip to content

Handle Nothing in TestSuite.compare #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
starkmarkus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle Nothing in TestSuite.compare #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/testsuite.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ using Test
using Adapt

test_result(@nospecialize(a), @nospecialize(b); kwargs...) = a == b
test_result(::Nothing, ::Nothing; kwargs...) = true
test_result(::Nothing, @nospecialize(b); kwargs...) = false
test_result(@nospecialize(a), ::Nothing; kwargs...) = false
test_result(a::Number, b::Number; kwargs...) = ≈(a, b; kwargs...)
test_result(a::Missing, b::Missing; kwargs...) = true
test_result(a::Number, b::Missing; kwargs...) = false
Expand Down
1 change: 1 addition & 0 deletions test/testsuite/indexing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ end
# 1D
@test compare(findfirst, AT, rand(Bool, 100))
@test compare(x->findfirst(>(0.5f0), x), AT, rand(Float32, 100))
@test compare(findfirst, AT, fill(false, 10))
let x = fill(false, 10)
@test findfirst(x) == findfirst(AT(x))
end
Expand Down