Skip to content

Commit 8c8cadc

Browse files
authored
replace unsigned only varint calls with encode_varint! (#43)
- Replace encode_signed_varint with encode_varint for FloatIdentityOp bits since float_to_bits returns unsigned values - Remove redundant encode_signed_varint overload in writer.jl that just wrapped encode_varint anyway
1 parent 2c52a53 commit 8c8cadc

1 file changed

Lines changed: 2 additions & 13 deletions

File tree

src/bytecode/writer.jl

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ function encode_tagged_float!(cb::CodeBuilder, identity::FloatIdentity)
264264
encode_typeid!(cb.buf, identity.type_id)
265265
# Value as bits (using signed varint encoding for values <= 64 bits)
266266
bits = float_to_bits(identity.value, identity.dtype)
267-
encode_signed_varint!(cb.buf, bits)
267+
encode_varint!(cb.buf, bits)
268268
end
269269

270270
"""
@@ -290,17 +290,6 @@ function float_to_bits(value::Float64, ::Type{T}) where T
290290
reinterpret(UInt32, Float32(value))
291291
end
292292

293-
"""
294-
encode_signed_varint!(buf, value)
295-
296-
Encode a signed integer as a variable-length integer.
297-
Uses zigzag encoding for signed values.
298-
"""
299-
function encode_signed_varint!(buf::Vector{UInt8}, value::Union{UInt16, UInt32, UInt64})
300-
# For float bits, encode as unsigned varint
301-
encode_varint!(buf, UInt64(value))
302-
end
303-
304293
"""
305294
encode_identity_array!(cb, identities)
306295
@@ -544,7 +533,7 @@ function finalize_function!(func_buf::Vector{UInt8}, cb::CodeBuilder,
544533
end
545534

546535
#=============================================================================
547-
Optimization Hints
536+
Optimization Hints
548537
=============================================================================#
549538

550539
"""

0 commit comments

Comments
 (0)