You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Cuts the number of dependencies in the examples/ environment in half by using CUDA directly, allowing the dependencies of the test/ environment to be a superset with the addition of only NVTX and FFTW. This eliminates the need to reset the active project to the examples/ environment.
I encountered this problem in #239 while wanting to quickly run tests in a fresh cloud environment:
Otherwise I'd have to clone, activate by path, and instantiate.
This should only make running an example / benchmark slightly slower, since cuSOLVER, cuSPARSE, and CUDATools are now indirect dependencies of examples/.
The issue is specifically when the cuTile workspace hasn't been instantiated. If we only add cuTile to an external environment, FFTW and others (which previously only existed in cuTile/examples) are never added.
Ugh, I didn't realize Pkg.test doesn't instantiate sibling-workspaces. Other Pkg APIs take a workspace argument for that, so I guess we could add that to the Buildkite plugin that calls Pkg.instantiate, but that doesn't fix the case where a fresh clone would break doing Pkg.test.
@KristofferC Any thoughts here? A summary: We have both a test and examples environment, grouped in a workspace, and it turns out Pkg.test doesn't instantiate the examples environment. That's unfortunate because in the test suite we're switching to the examples environment to run the examples. A workspace argument to Pkg.test seems weird, but would allow me to keep the environments here clean. Instead we have to add "artificial" dependencies to the test environment, just like we had to before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts the number of dependencies in the examples/ environment in half by using CUDA directly, allowing the dependencies of the test/ environment to be a superset with the addition of only NVTX and FFTW. This eliminates the need to reset the active project to the examples/ environment.
I encountered this problem in #239 while wanting to quickly run tests in a fresh cloud environment:
Otherwise I'd have to clone, activate by path, and instantiate.
This should only make running an example / benchmark slightly slower, since cuSOLVER, cuSPARSE, and CUDATools are now indirect dependencies of examples/.