Conversation
|
The errors seem unrelated to the PR... |
Yes, my sincere apologies! Turns out AbstractGPs 0.5.10 was breaking after all 😞 @theogf once you've merged JuliaGaussianProcesses/AbstractGPs.jl#310 (& released) and #125, the build issues should be solely due to your own mistakes again ;) |
st--
left a comment
There was a problem hiding this comment.
Yay! looks great. The only thing I'd prefer changed is for it not to be called "example.md".... is it not possible to have it by name.md as before? if it's got to be hardcoded I'd prefer index.md ...
It is much easier to have a fixed name (this follow the same constraint as the "script.jl" thing. But sure we could go for another name |
|
@devmotion was already using index.md, let's go with this then |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…eGPs.jl into tgf/juliagpsdocs
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 4 4
Lines 284 284
=======================================
Hits 265 265
Misses 19 19 Continue to review full report at Codecov.
|
|
Seems to be working fine now. Great job @theogf 🎉 |
Time for battle testing!