Skip to content

Initial proof-of-concept Expectation Propagation#64

Open
st-- wants to merge 113 commits into
masterfrom
st/ExpectationPropagation
Open

Initial proof-of-concept Expectation Propagation#64
st-- wants to merge 113 commits into
masterfrom
st/ExpectationPropagation

Conversation

@st--

@st-- st-- commented Oct 1, 2021

Copy link
Copy Markdown
Member

This is a very basic version to demonstrate proof-of-concept. See #92 for missing features.

@st-- st-- mentioned this pull request Jan 11, 2022
Comment thread src/ep.jl Outdated
Comment thread src/laplace.jl Outdated
st-- and others added 5 commits January 11, 2022 11:39
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…rocesses/ApproximateGPs.jl into st/ExpectationPropagation
Comment thread src/ep.jl Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@st-- st-- changed the title Expectation Propagation Initial proof-of-concept Expectation Propagation Jan 11, 2022
@st-- st-- requested a review from theogf January 13, 2022 08:47
@st--

st-- commented Jan 13, 2022

Copy link
Copy Markdown
Member Author

Why are the tests failing when all I did was merge in master (with #76)? 😢

@devmotion

devmotion commented Jan 13, 2022

Copy link
Copy Markdown
Member

Caused by JuliaDiff/ChainRules.jl#559 it seems (similar to issues in Distributions, DistributionsAD, NNlib etc.). Should be fixed by the new ChainRules release (bugfix was JuliaDiff/ChainRules.jl#562).

Comment thread src/ep.jl Outdated
st-- and others added 2 commits January 14, 2022 10:39
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@st--

st-- commented Jan 14, 2022

Copy link
Copy Markdown
Member Author

Caused by JuliaDiff/ChainRules.jl#559 it seems (similar to issues in Distributions, DistributionsAD, NNlib etc.). Should be fixed by the new ChainRules release (bugfix was JuliaDiff/ChainRules.jl#562).

Thanks @devmotion ! it seems to be passing again :)

@st--

st-- commented Jan 18, 2022

Copy link
Copy Markdown
Member Author

@theogf what do you think of this as a first stab ?

Comment thread test/ExpectationPropagationModule.jl Outdated
Comment thread test/runtests.jl Outdated
st-- and others added 2 commits March 21, 2022 09:30
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants