GeoInterface improvements#264
Merged
Merged
Conversation
Member
Author
|
We need to add GI.testgeometry on sample geoms of all dimensions. That should also bump up coverage generally. |
asinghvi17
commented
Oct 3, 2025
| geointerface_geomtype(::GeoInterface.MultiPointTrait) = MultiPoint | ||
| geointerface_geomtype(::GeoInterface.LineTrait) = Line | ||
| geointerface_geomtype(::GeoInterface.LineStringTrait) = LineString | ||
| geointerface_geomtype(::GeoInterface.LinearRingTrait) = LineString |
Member
Author
There was a problem hiding this comment.
Lol I just ran into this again, we should get this in!
Contributor
There was a problem hiding this comment.
I feel like I have also fixed this multiple times locally 😭
Contributor
There was a problem hiding this comment.
Get the codecov bot onto it? I'm not a member here
Tests the new GeoInterface.convert for LineTrait → Line (2D and 3D) and LinearRingTrait → LineString (2D and 3D) to improve codecov. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
This only affects GeoInterface so I don't think this needs review from the GeometryBasics side? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeoInterface.convertforLineTrait→GeometryBasics.Line(2D and 3D)GeoInterface.convertforLineStringto also acceptLinearRingTrait, so converting anyPolygon(which hasLinearRingexterior/holes) works correctlygeointerface_geomtype(::LinearRingTrait) = LineStringLineconversion, 2D and 3DLinearRing→LineStringconversion)