Skip to content

Update Doc Cleanup action to run monthly#2

Merged
juliohm merged 2 commits into
mainfrom
doc-cleanup
Jun 23, 2026
Merged

Update Doc Cleanup action to run monthly#2
juliohm merged 2 commits into
mainfrom
doc-cleanup

Conversation

@eliascarv

@eliascarv eliascarv commented Jun 23, 2026

Copy link
Copy Markdown
Member

Update the action with the new features implemented in JuliaML/TableTransforms.jl#323.

@eliascarv eliascarv requested a review from juliohm June 23, 2026 16:25
@juliohm

juliohm commented Jun 23, 2026

Copy link
Copy Markdown
Member

Thank you @eliascarv for improving our actions. We really need to take care of these doc builds, otherwise they pollute our git history.

I will ask the help of @JoshuaLampert as he knows these actions in more depth.

@juliohm juliohm requested a review from JoshuaLampert June 23, 2026 16:31
@juliohm

juliohm commented Jun 23, 2026

Copy link
Copy Markdown
Member

@JoshuaLampert to give you more context: we are trying to clean old docs every now and then to save storage on GitHub. If they consume all the storage, the docs build fails.

We already save the docs in a separate repo to avoid blowing up the Meshes.jl repo with various commits to gh-pages with Makie.jl figures.

Comment thread .github/workflows/DocCleanup.yml Outdated
git config user.email "documenter@juliadocs.github.io"
git rm -rf v[0-9]*.[0-9]* && git checkout HEAD -- $keep
if git commit -m "keep latest docs only" ; then
git rm -rf --ignore-unmatch v[0-9]*.[0-9]*

@JoshuaLampert JoshuaLampert Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaLampert, I wanted to implement logic to delete previews only for PRs that have already been merged/closed, while keeping the previews for open PRs.
However, simply clearing the folder seems like a reasonable option to me.
What do you think, @juliohm?

@juliohm

juliohm commented Jun 23, 2026 via email

Copy link
Copy Markdown
Member

@eliascarv

Copy link
Copy Markdown
Member Author

@juliohm great, I'll adjust the PR after running tests on a fork.

@eliascarv eliascarv requested a review from JoshuaLampert June 23, 2026 19:56
@juliohm

juliohm commented Jun 23, 2026

Copy link
Copy Markdown
Member

Thank you @eliascarv, appreciate it if you could reproduce this new setting in the other PRs to GeoStatsDocs and TableTransforms.jl. That way we get the same behavior across projects.

@eliascarv

Copy link
Copy Markdown
Member Author

@JoshuaLampert ready for final review.

@JoshuaLampert JoshuaLampert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@juliohm juliohm merged commit dc05709 into main Jun 23, 2026
@juliohm juliohm deleted the doc-cleanup branch June 23, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants