Skip to content

Keep Julia ownership when setting values in a JuliaPropertyMap #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barche merged 1 commit into from
Jun 24, 2026
Merged

Keep Julia ownership when setting values in a JuliaPropertyMap #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "QML"
uuid = "2db162a6-7e43-52c3-8d84-290c1c42d82a"
version = "0.13.1"
version = "0.13.2"
authors = ["Bart Janssens <bart@bartjanssens.org>"]

[deps]
Expand Down Expand Up @@ -30,7 +30,7 @@ MacroTools = "0.5"
Observables = "0.5"
Qt6Svg_jll = "6.10"
Qt6Wayland_jll = "6.10"
jlqml_jll = "0.10.2"
jlqml_jll = "0.10.3"
julia = "1.10"

[extras]
Expand Down
4 changes: 4 additions & 0 deletions src/QML.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,10 @@ end
# QQmlPropertyMap indexing interface
Base.getindex(propmap::QQmlPropertyMap, key::AbstractString) = value(value(propmap, key))
Base.setindex!(propmap::QQmlPropertyMap, val, key::AbstractString) = insert(propmap, QString(key), QVariant(val))
function Base.setindex!(propmap::QQmlPropertyMap, val::QObject, key::AbstractString)
insert(propmap, QString(key), QVariant(val))
setObjectOwnership(CxxPtr(val), CppOwnership)
end
Base.setindex!(propmap::QQmlPropertyMap, val::QVariant, key::AbstractString) = insert(propmap, key, val)
Base.setindex!(propmap::QQmlPropertyMap, val::Irrational, key::AbstractString) = (propmap[key] = convert(Float64, val))

Expand Down
Loading