Split makie support into a separate JlCxx module so it can be wrapped by a separate package#23
Conversation
|
Thanks, I fully agree to keep the C++ code in one place, it doesn't add any special dependencies here and keeping two C++ JLLs in sync would be difficult. I also don't expect we will need to add much here, I prefer to implement as much as possible on the Julia side. |
|
I noticed CI failed on macOS. Is that normal? I didn't think much more about it, seeing as you got it working, but now that I'm trying to move the application I'm developing at work over to use QMLMakie, I'm having some trouble compiling Or rather, I can compile it just fine at first glance, but when i then If I modify the cmake flags with If I manually I think the reason this ultimately happens, is that |
|
Ah, yes, there have been many additions to libcxxwrap during this year's Google Summer of Code. I think you need to build libcxxwrap from source for this to work, but we triggered a bug in clang and it literally takes hours to compile now, so this is cumbersome. I have tested your code only on my Linux machine, but there is no inherent reason why it should cause problems, so any issues on Mac are undoubdetly related to libcxxwrap changes. |
|
I tried, and I noticed that. So is it effectively impossible to build on macOS for the time being? I guess I can leave it compiling overnight :-p |
This is probably not quite ready for a merge, but I'm starting a PR so we have a place to discuss where to go from here, and for visibility in case someone wants to play around with it or help out.
This PR supports JuliaGraphics/QML.jl#207.
I opted to keep the C++ code backing QMLMakie in here for now. In the long term it might be interesting to separate it into its own JLL if it becomes huge, but I couldn't quite figure out the logistics of making a new JLL that links to this one so the Makie component can extend the generic OpenGL component.