Skip to content

Avoid scalar indexing in remove_edges #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alonsoC1s wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid scalar indexing in remove_edges #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions GNNGraphs/src/GNNGraphs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module GNNGraphs

using SparseArrays
import Graphs
using Graphs: AbstractGraph, outneighbors, inneighbors, adjacency_matrix, degree,
using Graphs: AbstractGraph, outneighbors, inneighbors, adjacency_matrix, degree,
has_self_loops, is_directed, induced_subgraph, has_edge
import NearestNeighbors
import NNlib
Expand All @@ -11,7 +11,7 @@ import KrylovKit
import ChainRulesCore as CRC
using LinearAlgebra, Random, Statistics
import MLUtils
using MLUtils: getobs, numobs, ones_like, zeros_like, chunk, batch, rand_like
using MLUtils: getobs, numobs, ones_like, zeros_like, fill_like, chunk, batch, rand_like
using MLDataDevices: get_device, cpu_device, CPUDevice
using Functors: @functor

Expand All @@ -38,9 +38,9 @@ export GNNHeteroGraph,
include("temporalsnapshotsgnngraph.jl")
export TemporalSnapshotsGNNGraph,
add_snapshot,
# add_snapshot!,
# add_snapshot!,
remove_snapshot
# remove_snapshot!
# remove_snapshot!

include("query.jl")
include("gnnheterograph/query.jl")
Expand All @@ -59,7 +59,7 @@ export adjacency_list,
# from Graphs.jl
adjacency_matrix,
degree,
has_edge,
has_edge,
has_isolated_nodes,
has_self_loops,
inneighbors,
Expand All @@ -75,7 +75,7 @@ export add_nodes,
negative_sample,
rand_edge_split,
remove_self_loops,
remove_edges,
remove_edges,
coalesce,
set_edge_weight,
to_bidirected,
Expand Down Expand Up @@ -117,7 +117,7 @@ export mldataset2gnngraph
include("deprecations.jl")

include("sampling.jl")
export NeighborLoader, sample_neighbors,
induced_subgraph # from Graphs.jl
export NeighborLoader, sample_neighbors,
induced_subgraph # from Graphs.jl

end #module
3 changes: 2 additions & 1 deletion GNNGraphs/src/transform.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ function remove_edges(g::GNNGraph{<:COO_T}, edges_to_remove::AbstractVector{<:In
w = get_edge_weight(g)
edata = g.edata

mask_to_keep = trues(length(s))
# mask_to_keep = trues(length(s))
mask_to_keep = MLUtils.fill_like(edges_to_remove, true)

mask_to_keep[edges_to_remove] .= false

Expand Down
Loading