Add complete AbstractGraph API and LEMON algorithm dispatch#25
Draft
AJ0070 wants to merge 3 commits into
Draft
Conversation
Member
Author
|
this was a large diff so took me good amount of time and was also parallely working on networkx issue |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 80.00% 72.43% -7.57%
==========================================
Files 1 3 +2
Lines 20 156 +136
==========================================
+ Hits 16 113 +97
- Misses 4 43 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
failures are same as on main |
Member
Author
|
@Krastanov Can I get review on this? |
Member
Author
|
WIP: I will ping Krastanov once this is ready for review. this still requires good amount of work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major Changes:
(nv, ne, vertices, edges, has_vertex, has_edge, inneighbors, outneighbors, is_directed, edgetype)
Fixes JuliaGraphs/Graphs.jl#447
AI Usage:
used GitHub copilot on auto mode.
Initially I generated skeleton with the AI. Implemented everything myself (used copilot whenever I felt complexity is high and I need to understand this more thoroughly). Then some key tests my self and asked copilot to give me complete test coverage so I don't miss out any edge cases (removed some unnecessary test it added). Then at last I asked him to update documentation according to the changes in the code (It added so many useless thing which I cleaned up).