Skip to content

Adjust cglobal to be statically evaluated#65

Merged
mxhbl merged 1 commit into
JuliaGraphs:mainfrom
topolarity:ct/static-cglobal
May 6, 2026
Merged

Adjust cglobal to be statically evaluated#65
mxhbl merged 1 commit into
JuliaGraphs:mainfrom
topolarity:ct/static-cglobal

Conversation

@topolarity

Copy link
Copy Markdown
Contributor

Calling a function like libnauty(UInt16) inside a cglobal is likely to be removed in future versions of Julia by JuliaLang/julia#61709.

The trouble is that this behavior only works inconsistently, depending on whether the argument happens to statically evaluable in the world age computed by inference and furthermore the dynamic cglobal form is incompatible with --trim.

The "static" form resolves these issues and is compatible with future versions of Julia.

@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.96%. Comparing base (2293ebd) to head (6b5afc2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files           8        8           
  Lines         775      775           
=======================================
  Hits          736      736           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mxhbl

mxhbl commented May 6, 2026

Copy link
Copy Markdown
Member

Awesome, thanks!

@mxhbl
mxhbl merged commit 435f904 into JuliaGraphs:main May 6, 2026
6 of 7 checks passed
@topolarity

Copy link
Copy Markdown
Contributor Author

@mxhbl Thanks for merging!

Would it be possible to get a release with this fix?

@mxhbl

mxhbl commented Jun 25, 2026

Copy link
Copy Markdown
Member

Of course, thanks for reminding me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants