Refactor: Split monolithic source into dedicated files#1
Merged
Conversation
Move each logical concern into its own file following IGraphs.jl style: - src/python_networkx.jl — PythonNetworkX sub-module - src/types.jl — AbstractNetworkXGraph, NetworkXGraph, NetworkXDiGraph, constructors - src/graph_api.jl — All Graphs.jl interface method implementations - src/conversions.jl — networkx_graph() converters src/NetworkXGraphs.jl is now a lean entry-point with include() calls only. No behaviour change; all 38 tests pass.
Member
Author
|
@Krastanov can I get review on this? |
Krastanov
approved these changes
Apr 29, 2026
Member
Krastanov
left a comment
Krastanov
left a comment
There was a problem hiding this comment.
on a skim, it looks good. I doubt there will be the bandwidth for a proper review, so let's not have this die out on the fine and proceed with merging
Could you look into expanding the testing infrastructure next, to make trust in PRs a bit higher. Get Aqua and JET, maybe a formatter, ImplicitImport checks, and CI on more platforms and on nightly. Check Graphs.jl for how it is done there.
Feel free to merge approved PRs yourself.
Member
|
(oh, and code coverage too, TagBot, dependabot, downgrade checks, etc) |
Member
Author
|
Sure, I'll do that in my next PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
src/NetworkXGraphs.jlby splitting its monolithic implementation into several dedicated files, improving maintainability and aligning the codebase with established JuliaGraphs conventions (such asIGraphs.jl).Changes:
PythonNetworkXsub-module intosrc/python_networkx.jlAbstractNetworkXGraph,NetworkXGraph,NetworkXDiGraph) tosrc/types.jlGraphs.jlAPI implementations tosrc/graph_api.jlnetworkx_graph) tosrc/conversions.jlsrc/NetworkXGraphs.jlto serve purely as the package entry-point.This is a structural refactoring only; there are no behavioral changes to the API.