Skip to content

Remove @inbounds in _fvrange and _bvrange#45

Merged
simsurace merged 2 commits into
masterfrom
fix-inbounds
Nov 11, 2025
Merged

Remove @inbounds in _fvrange and _bvrange#45
simsurace merged 2 commits into
masterfrom
fix-inbounds

Conversation

@simsurace

Copy link
Copy Markdown
Member

Closes #33. It's probably safest to remove these, unless putting them back and putting checks elsewhere can be shown to be significantly more performant.

@simsurace simsurace requested a review from Krastanov November 2, 2025 23:24

@Krastanov Krastanov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a test? Otherwise looks good to merge without further review.

@simsurace simsurace merged commit 2c0c5e7 into master Nov 11, 2025
2 checks passed
@simsurace simsurace deleted the fix-inbounds branch November 11, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

neighbors segfaults on large out of bounds indices

2 participants