Skip to content

Fix flaky OGG/MATROSKA test downloads#432

Merged
ViralBShah merged 1 commit intomasterfrom
fix-try-download-catch
Apr 12, 2026
Merged

Fix flaky OGG/MATROSKA test downloads#432
ViralBShah merged 1 commit intomasterfrom
fix-try-download-catch

Conversation

@ViralBShah
Copy link
Copy Markdown
Member

@ViralBShah ViralBShah commented Apr 12, 2026

Summary

  • The try_download helper in tests caught only Downloads.RequestError, but this type check failed on some Julia versions when wikimedia returned HTTP 429 (rate limit)
  • Changed to catch all exceptions, since any download failure should gracefully skip the test via @test_skip
  • Fixes the CI failures seen in Bump codecov/codecov-action from 5 to 6 #429 (and likely other PRs hitting the same wikimedia rate limiting)

Test plan

  • CI passes on all Julia versions (1.6, lts, nightly)
  • OGG/MATROSKA tests either pass (successful download) or skip gracefully (download failure)

🤖 Generated with Claude Code

The try_download catch block checked `e isa Downloads.RequestError`,
but this didn't match on some Julia versions when wikimedia returned
HTTP 429 (rate limit). Catch all exceptions since any download failure
should gracefully skip the test.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.44%. Comparing base (4e544bd) to head (d3f4a60).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files          11       11           
  Lines         713      713           
=======================================
  Hits          652      652           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah merged commit aa0355d into master Apr 12, 2026
17 checks passed
@ViralBShah ViralBShah deleted the fix-try-download-catch branch April 12, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant