From d3f4a609edd7463eba8ba546a4eac5908382144d Mon Sep 17 00:00:00 2001 From: "Viral B. Shah" Date: Sun, 12 Apr 2026 00:04:27 -0400 Subject: [PATCH] Fix flaky OGG/MATROSKA tests by catching all download exceptions The try_download catch block checked `e isa Downloads.RequestError`, but this didn't match on some Julia versions when wikimedia returned HTTP 429 (rate limit). Catch all exceptions since any download failure should gracefully skip the test. Co-Authored-By: Claude Opus 4.6 (1M context) --- test/query.jl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/query.jl b/test/query.jl index a70f096..d3b2ac9 100644 --- a/test/query.jl +++ b/test/query.jl @@ -408,9 +408,8 @@ let file_dir = joinpath(@__DIR__, "files"), file_path = Path(file_dir) function try_download(url) try return Downloads.download(url) - catch e - e isa Downloads.RequestError && return nothing - rethrow() + catch + return nothing end end if Base.VERSION >= v"1.6" || !Sys.iswindows()