Skip to content

Add row/column-major order documentation#805

Merged
musm merged 4 commits into
JuliaIO:masterfrom
qin-yu:qy/fix785-doc-order
Jan 18, 2021
Merged

Add row/column-major order documentation#805
musm merged 4 commits into
JuliaIO:masterfrom
qin-yu:qy/fix785-doc-order

Conversation

@qin-yu
Copy link
Copy Markdown
Contributor

@qin-yu qin-yu commented Jan 14, 2021

Tries to fix #785

Add short descriptions in README and documentation to warn users about the two methods for storing multidimensional arrays.

@qin-yu
Copy link
Copy Markdown
Contributor Author

qin-yu commented Jan 14, 2021

@musm @jmert any comment/advice?

Comment thread README.md Outdated
Comment thread docs/src/index.md Outdated
@qin-yu qin-yu closed this Jan 14, 2021
@qin-yu qin-yu force-pushed the qy/fix785-doc-order branch from e366e66 to 88a64e2 Compare January 14, 2021 20:42
@qin-yu qin-yu reopened this Jan 14, 2021
@qin-yu
Copy link
Copy Markdown
Contributor Author

qin-yu commented Jan 14, 2021

I just noticed there is another PR with a page of details! Somehow the GitHub homepage doesn't update if a PR refers to our issue, so I didn't notice. I believe the issue itself combines with #804 is more than enough to provide some essential information on this.

Any comment on the new version? @musm If you think it's bad or you don't want merge both PR, I wouldn't mind if you close this PR in favor of the other one.

Comment thread docs/src/index.md Outdated
Comment thread docs/src/index.md Outdated
qin-yu and others added 2 commits January 15, 2021 10:03
Co-authored-by: Mustafa M <mus-m@outlook.com>
Comment thread docs/src/index.md Outdated
Comment thread docs/src/index.md Outdated
Co-authored-by: Mustafa M <mus-m@outlook.com>
@musm
Copy link
Copy Markdown
Member

musm commented Jan 18, 2021

Thanks!

@musm musm merged commit c6e57b4 into JuliaIO:master Jan 18, 2021
@qin-yu qin-yu deleted the qy/fix785-doc-order branch January 18, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-dimensional arrays have reversed order if loaded by h5py in Python3

2 participants