Try gc preserve for ptrstring

Author: quinnj

src/lazy.jl

@@ -270,17 +270,19 @@ function applyobject(keyvalfunc, x::LazyValues)
     b == UInt8('}') && return pos + 1
     while true
         # parsestring returns key as a PtrString
-        key, pos = @inline parsestring(LazyValue(buf, pos, JSONTypes.STRING, opts, false))
-        @nextbyte
-        if b != UInt8(':')
-            error = ExpectedColon
-            @goto invalid
+        GC.@preserve buf begin
+            key, pos = @inline parsestring(LazyValue(buf, pos, JSONTypes.STRING, opts, false))
+            @nextbyte
+            if b != UInt8(':')
+                error = ExpectedColon
+                @goto invalid
+            end
+            pos += 1
+            @nextbyte
+            # we're now positioned at the start of the value
+            val = _lazy(buf, pos, len, b, opts)
+            ret = keyvalfunc(key, val)
         end
-        pos += 1
-        @nextbyte
-        # we're now positioned at the start of the value
-        val = _lazy(buf, pos, len, b, opts)
-        ret = keyvalfunc(key, val)
         # if ret is an EarlyReturn, then we're short-circuiting
         # parsing via e.g. selection syntax, so return immediately
         ret isa StructUtils.EarlyReturn && return ret
@@ -732,8 +734,11 @@ function Base.show(io::IO, x::LazyValue)
             show(io, MIME"text/plain"(), la)
         end
     elseif T == JSONTypes.STRING
-        str, _ = parsestring(x)
-        Base.print(io, "JSON.LazyValue(", repr(convert(String, str)), ")")
+        buf = getbuf(x)
+        GC.@preserve buf begin
+            str, _ = parsestring(x)
+            Base.print(io, "JSON.LazyValue(", repr(convert(String, str)), ")")
+        end
     elseif T == JSONTypes.NULL
         Base.print(io, "JSON.LazyValue(nothing)")
     else # bool/number

src/parse.jl

@@ -277,8 +277,11 @@ function applyvalue(f, x::LazyValues, null)
         f(arr)
         return pos
     elseif type == JSONTypes.STRING
-        str, pos = parsestring(x)
-        f(convert(String, str))
+        buf = getbuf(x)
+        GC.@preserve buf begin
+            str, pos = parsestring(x)
+            f(convert(String, str))
+        end
         return pos
     elseif type == JSONTypes.NUMBER
         num, pos = parsenumber(x)
@@ -344,8 +347,10 @@ end
 function StructUtils.lift(style::StructStyle, ::Type{T}, x::LazyValues, tags=(;)) where {T}
     type = gettype(x)
     if type == JSONTypes.STRING
-        ptrstr, pos = parsestring(x)
-        str, _ = StructUtils.lift(style, T, ptrstr, tags)
+        GC.@preserve buf begin
+            ptrstr, pos = parsestring(x)
+            str, _ = StructUtils.lift(style, T, ptrstr, tags)
+        end
         return str, pos
     elseif type == JSONTypes.NUMBER
         num, pos = parsenumber(x)
@@ -448,7 +453,9 @@ end
         Base.@nexprs $N i -> begin
             if typ == JSONTypes.OBJECT
                 # consume key
-                _, pos = @inline parsestring(LazyValue(buf, pos, JSONTypes.STRING, opts, false))
+                GC.@preserve buf begin
+                    _, pos = @inline parsestring(LazyValue(buf, pos, JSONTypes.STRING, opts, false))
+                end
                 @nextbyte
                 if b != UInt8(':')
                     error = ExpectedColon
@@ -483,7 +490,9 @@ end
         while true
             if typ == JSONTypes.OBJECT
                 # consume key
-                _, pos = @inline parsestring(LazyValue(buf, pos, JSONTypes.STRING, opts, false))
+                GC.@preserve buf begin
+                    _, pos = @inline parsestring(LazyValue(buf, pos, JSONTypes.STRING, opts, false))
+                end
                 @nextbyte
                 if b != UInt8(':')
                     error = ExpectedColon