Fix misleading error message for lowerkey#426
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
=======================================
Coverage 90.26% 90.26%
=======================================
Files 7 7
Lines 1366 1366
=======================================
Hits 1233 1233
Misses 133 133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
quinnj
force-pushed
the
fix-414-lowerkey-error-message
branch
from
3cc21be to
71d7f74
Compare
The error message now correctly suggests defining `StructUtils.lowerkey(::JSON.JSONStyle, ::T)` instead of `StructUtils.lowerkey(::T)` which doesn't work. Fixes #414 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
quinnj
force-pushed
the
fix-414-lowerkey-error-message
branch
from
71d7f74 to
6630ae8
Compare
quinnj
referenced
this pull request
Jan 14, 2026
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StructUtils.lowerkeyto suggest the correct method signatureThe current error message tells users to define
StructUtils.lowerkey(::T), but the correct signature requires theJSONStyleargument:StructUtils.lowerkey(::JSON.JSONStyle, ::T).Test plan
Fixes #414
🤖 Generated with Claude Code