From 06ad3eefd2be971395d3caff073190290b5307ad Mon Sep 17 00:00:00 2001
From: hhaensel <helmut.haensel@gmx.com>
Date: Mon, 12 Jan 2026 10:49:17 +0100
Subject: [PATCH] add methods for setindex!, delete!, haskey for
 obj::Object{String}, key::Symbol and vice versa plus respective tests

---
 src/object.jl  |  5 +++++
 test/object.jl | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 56 insertions(+)

diff --git a/src/object.jl b/src/object.jl
index f3ec00f1..5c371b5c 100644
--- a/src/object.jl
+++ b/src/object.jl
@@ -140,6 +140,10 @@ end
 Base.getindex(obj::Object, key) = get(() -> throw(KeyError(key)), obj, key)
 Base.getindex(obj::Object{String}, key::Symbol) = get(() -> throw(KeyError(key)), obj, String(key))
 Base.getindex(obj::Object{Symbol}, key::String) = get(() -> throw(KeyError(key)), obj, Symbol(key))
+Base.setindex!(obj::Object{String}, value, key::Symbol) = setindex!(obj, value, String(key))
+Base.setindex!(obj::Object{Symbol}, value, key::String) = setindex!(obj, value, Symbol(key))
+Base.delete!(obj::Object{String}, key::Symbol) = delete!(obj, String(key))
+Base.delete!(obj::Object{Symbol}, key::String) = delete!(obj, Symbol(key))
 Base.get(obj::Object, key, default) = get(() -> default, obj, key)
 
 # support getproperty for dot access
@@ -155,6 +159,7 @@ end
 # haskey
 Base.haskey(obj::Object, key) = find_node_by_key(obj, key) !== nothing
 Base.haskey(obj::Object{String}, key::Symbol) = haskey(obj, String(key))
+Base.haskey(obj::Object{Symbol}, key::String) = haskey(obj, Symbol(key))
 
 # setindex! finds node with key and sets value or inserts a new node
 function Base.setindex!(obj::Object{K,V}, value, key::K) where {K,V}
diff --git a/test/object.jl b/test/object.jl
index cd166a64..62797952 100644
--- a/test/object.jl
+++ b/test/object.jl
@@ -268,12 +268,63 @@ using JSON, Test
         @test haskey(obj, :symbol_test)
         @test !haskey(obj, :nonexistent_symbol)
 
+        # Test that indexing with both String and Symbol keys work
+        @test obj[:symbol_test] == obj["symbol_test"]
+        
+        # Test overwriting with Symbol key 
+        obj[:symbol_test] = "newvalue"
+        @test obj[:symbol_test] == obj["symbol_test"] == "newvalue"
+
+        # Test deletion with Symbol key
+        delete!(obj, :symbol_test)
+        @test !haskey(obj, :symbol_test)
+        @test !haskey(obj, "symbol_test")
+        
         # Test with empty object
         empty_obj = JSON.Object{String, Any}()
         @test !haskey(empty_obj, :anything)
         @test !haskey(empty_obj, "anything")
     end
 
+    # Test enhanced haskey for Symbol objects with String keys
+    @testset "Enhanced haskey for Symbol Objects" begin
+        obj = JSON.Object{Symbol, Any}()
+        obj[:hello] = "world"
+        obj[:count] = 42
+
+        # Test basic string key lookup
+        @test haskey(obj, :hello)
+        @test haskey(obj, :count)
+        @test !haskey(obj, :missing)
+        
+        # Test String key lookup (should convert to Symbol)
+        @test haskey(obj, "hello")
+        @test haskey(obj, "count")
+        @test !haskey(obj, "missing")
+
+        # Test that String keys work for both existing and non-existing keys
+        obj[:symbol_test] = "value"
+        @test haskey(obj, "symbol_test")
+        @test !haskey(obj, "nonexistent_symbol")
+
+        # Test that indexing with both String and Symbol keys work
+        @test obj[:symbol_test] == obj["symbol_test"]
+
+        # Test overwriting with String key 
+        obj["symbol_test"] = "newvalue"
+        @test obj[:symbol_test] == obj["symbol_test"] == "newvalue"
+
+        # Test deletion with String key
+        delete!(obj, "symbol_test")
+        @test !haskey(obj, :symbol_test)
+        @test !haskey(obj, "symbol_test")
+
+        # Test with empty object
+        empty_obj = JSON.Object{Symbol, Any}()
+        @test !haskey(empty_obj, :anything)
+        @test !haskey(empty_obj, "anything")
+    end
+
     # Test merge functionality with NamedTuple
     @testset "NamedTuple Merge" begin
         # Test basic merge