vendor/jsonx: improve correctness and performance#470
Open
fredrikekre wants to merge 1 commit into
Open
Conversation
- skip_whitespace: compare bytes directly against the 4 RFC 8259 whitespace characters instead of isspace(Char(...)). ~2x faster and correctly rejects vertical tab / form feed which isspace accepts but JSON does not. - parse_number: replace try/catch with tryparse — ~500x faster on the happy path, ~1400x on Int64 overflow. Also reject leading '+' which is not valid per the JSON spec. - parse_array: use explicit Any[] instead of untyped []. - tests: add cases for leading '+', vertical tab, and form feed. Co-Authored-By: Claude Code <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 90.41% 90.41%
=======================================
Files 7 7
Lines 1419 1419
=======================================
Hits 1283 1283
Misses 136 136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor things that Claude commented on while I was using the jsonx vendored
implementation. See commit message for details.