MAT_v4: Return variable name for zero-dimensional arrays#241
Open
foreverallama wants to merge 2 commits into
Open
MAT_v4: Return variable name for zero-dimensional arrays#241foreverallama wants to merge 2 commits into
foreverallama wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix reads and returns the variable name for zero-dimensional arrays. Variable names are written to MAT-files regardless of if they are empty or not. It also appears that the null terminator is not added for this case as well (may be related to #202 ?)
This was not accounted for previously, resulting in EOF error as it attempts to read the next variable header with only the name of the previous variable in the stream.
Fixes #240