Skip to content

Reduce allocs + improve benchmark table#74

Merged
csvance merged 2 commits into
mainfrom
reduce-allocs
Dec 5, 2025
Merged

Reduce allocs + improve benchmark table#74
csvance merged 2 commits into
mainfrom
reduce-allocs

Conversation

@csvance

@csvance csvance commented Dec 5, 2025

Copy link
Copy Markdown
Collaborator
  • Reduces allocations by using deleteat! instead of filter for remove gRPCRequest from gRPCCURL
  • Format URL with IOBuffer() and string() instead of interpolation
  • Format grpc-timeout with string() instead of interpolation
  • Remove the need to check for / replace grpc/grpcs with http/https

@codecov-commenter

codecov-commenter commented Dec 5, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.68%. Comparing base (eb373de) to head (e289687).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/Curl.jl 88.88% 1 Missing ⚠️
src/gRPC.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   85.65%   85.68%   +0.02%     
==========================================
  Files           7        7              
  Lines         509      510       +1     
==========================================
+ Hits          436      437       +1     
  Misses         73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@csvance csvance merged commit 75e4c28 into main Dec 5, 2025
13 checks passed
@csvance csvance deleted the reduce-allocs branch December 6, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants