Skip to content

Add a NoChannel type#80

Merged
csvance merged 1 commit into
JuliaIO:mainfrom
atthom:nochannel
Dec 12, 2025
Merged

Add a NoChannel type#80
csvance merged 1 commit into
JuliaIO:mainfrom
atthom:nochannel

Conversation

@atthom

@atthom atthom commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

I reported the changes from csvance/gRPCClient2.jl#27

There are still some warning in the Protobuf.jl file, because I used the main ProtoBuf.jl, not the forked version with codegen capabilities

@codecov-commenter

codecov-commenter commented Dec 10, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.41%. Comparing base (ad578fd) to head (6c8a607).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Curl.jl 72.22% 5 Missing ⚠️
src/Streaming.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   84.98%   84.41%   -0.57%     
==========================================
  Files           7        7              
  Lines         526      539      +13     
==========================================
+ Hits          447      455       +8     
- Misses         79       84       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atthom

atthom commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

It seems breaking on 1.10 on windows

@csvance

csvance commented Dec 11, 2025

Copy link
Copy Markdown
Collaborator

@atthom It's probobly more that the specific test that is failing isn't particuarly well designed in this case. The changes look great, this is an extremely elegant way to fix the JET errors without having to resort to un-idiomatic Julia code. My attempt to correct the JET issues looked horrendous compared to this.

@csvance

csvance commented Dec 11, 2025

Copy link
Copy Markdown
Collaborator

@atthom Github runners have been extremely flaky lately, it even made the news. The test passed now. If you are finished with the changes we can get them merged.

@csvance csvance self-assigned this Dec 11, 2025
@atthom

atthom commented Dec 12, 2025

Copy link
Copy Markdown
Contributor Author

Perfect, let's merge

@csvance csvance merged commit 55bd686 into JuliaIO:main Dec 12, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants