Add a NoChannel type#80
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 84.98% 84.41% -0.57%
==========================================
Files 7 7
Lines 526 539 +13
==========================================
+ Hits 447 455 +8
- Misses 79 84 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It seems breaking on 1.10 on windows |
|
@atthom It's probobly more that the specific test that is failing isn't particuarly well designed in this case. The changes look great, this is an extremely elegant way to fix the JET errors without having to resort to un-idiomatic Julia code. My attempt to correct the JET issues looked horrendous compared to this. |
|
@atthom Github runners have been extremely flaky lately, it even made the news. The test passed now. If you are finished with the changes we can get them merged. |
|
Perfect, let's merge |
I reported the changes from csvance/gRPCClient2.jl#27
There are still some warning in the Protobuf.jl file, because I used the main ProtoBuf.jl, not the forked version with codegen capabilities