Skip to content

Bump ProtoBuf dependency to ~1.2.1 (supports client stub codegen) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csvance merged 1 commit into from
Feb 22, 2026
Merged

Bump ProtoBuf dependency to ~1.2.1 (supports client stub codegen) #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ julia = "1.10"
FileWatching = "^1.10"
LibCURL = "~0.6.4, 1"
PrecompileTools = "^1.2"
ProtoBuf = "~1.2"
ProtoBuf = "~1.2.1"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
33 changes: 33 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,39 @@ include("gen/test/test_pb.jl")
# Initialize the global gRPCCURL structure
grpc_init()

@testset "Code Generation" begin
grpc_register_service_codegen()
mktempdir() do tmpdir
@test isnothing(protojl("proto/test.proto", @__DIR__, tmpdir))
generated = read(joinpath(tmpdir, "test", "test_pb.jl"), String)
# gRPCClient import injected after ProtoBuf imports
@test contains(generated, "import gRPCClient")
# BEGIN/END markers wrapping the service block
@test contains(generated, "# gRPCClient.jl BEGIN")
@test contains(generated, "# gRPCClient.jl END")
# All four service client constructors are present
@test contains(generated, "TestService_TestRPC_Client(")
@test contains(generated, "TestService_TestServerStreamRPC_Client(")
@test contains(generated, "TestService_TestClientStreamRPC_Client(")
@test contains(generated, "TestService_TestBidirectionalStreamRPC_Client(")
# Correct streaming type parameters for each RPC variant
@test contains(generated, "gRPCClient.gRPCServiceClient{TestRequest, false, TestResponse, false}")
@test contains(generated, "gRPCClient.gRPCServiceClient{TestRequest, false, TestResponse, true}")
@test contains(generated, "gRPCClient.gRPCServiceClient{TestRequest, true, TestResponse, false}")
@test contains(generated, "gRPCClient.gRPCServiceClient{TestRequest, true, TestResponse, true}")
# Correct fully-qualified RPC paths
@test contains(generated, "/test.TestService/TestRPC")
@test contains(generated, "/test.TestService/TestServerStreamRPC")
@test contains(generated, "/test.TestService/TestClientStreamRPC")
@test contains(generated, "/test.TestService/TestBidirectionalStreamRPC")
# Client constructors are exported (proto has a package namespace)
@test contains(generated, "export TestService_TestRPC_Client")
@test contains(generated, "export TestService_TestServerStreamRPC_Client")
@test contains(generated, "export TestService_TestClientStreamRPC_Client")
@test contains(generated, "export TestService_TestBidirectionalStreamRPC_Client")
end
end

@testset "@async varying request/response" begin
client = TestService_TestRPC_Client(_TEST_HOST, _TEST_PORT)

Expand Down