Skip to content

Commit 7ce61de

Browse files
DilumAluthgecodex
andcommitted
More stuff
Co-authored-by: OpenAI Codex GPT-5 <codex@openai.com>
1 parent de1274e commit 7ce61de

13 files changed

Lines changed: 382 additions & 2214 deletions

.github/dependabot.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ updates:
88
open-pull-requests-limit: 100
99

1010
- package-ecosystem: "npm"
11-
directory: "/test/"
11+
directory: "/test/node/"
1212
schedule:
1313
interval: "monthly"
1414
open-pull-requests-limit: 100

.github/workflows/CI.yml

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ jobs:
3232
fail-fast: false
3333
matrix:
3434
version:
35-
- 'lts'
36-
- '1'
35+
- '1.10' # currently the LTS
3736
steps:
3837
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # 6.0.2
3938
with:
@@ -50,7 +49,7 @@ jobs:
5049
# This job takes a long time (1+ hours).
5150
# So we intentionally skip this job on PR runs.
5251
# But we still run this job on Merge Queue jobs.
53-
if: github.event_name != 'pull_request'
52+
# if: github.event_name != 'pull_request' # TODO: Uncomment this line before merging the PR
5453
runs-on: ubuntu-latest
5554
timeout-minutes: 360
5655
strategy:
@@ -66,18 +65,18 @@ jobs:
6665
- name: Install dependencies
6766
run: julia --color=yes --project -e "using Pkg; Pkg.instantiate()"
6867
- name: Cleanup before we build
69-
run:
70-
rm -fv versions.json
68+
run: |
69+
make clean
7170
make nuke
7271
make purge_download_cache_dir
73-
- name: Download the old versions.json, so we can re-use it
72+
- name: Download the old versions.json, so we can re-use it and build on top of it
7473
run: curl -LO https://julialang-s3.julialang.org/bin/versions.json
7574
- name: Build versions.json
76-
run: make versions.json
75+
run: make build
7776
env:
78-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
77+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Used to authenticate to GitHub API to get list of tags
7978
- name: Run the post-build tests
80-
run: julia --project test/post_build.jl versions.json
79+
run: make test-full
8180
- name: Install NPM deps
8281
run: make _npm_ci
8382
- name: Validate versions.json against schema
@@ -96,7 +95,6 @@ jobs:
9695
if: github.event_name == 'workflow_dispatch' && github.ref == 'refs/heads/main'
9796
runs-on: ubuntu-latest
9897
timeout-minutes: 60
99-
10098
steps:
10199
- name: Download versions.json from previous job
102100
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
@@ -110,10 +108,10 @@ jobs:
110108
aws-region: ${{ env.aws_region }}
111109
- name: Upload versions.json to S3
112110
run: aws s3 cp versions.json s3://${{ env.s3_bucket }}/bin/versions.json --acl public-read --no-progress
113-
- name: Purge cache
111+
- name: Purge Fastly cache (Fastly sits in front of S3)
114112
run: curl -X PURGE https://julialang-s3.julialang.org/bin/versions.json
115113

116-
test-current-s3:
114+
test-current-s3-allowed-to-fail:
117115
# We intentionally do not make this job a "required status check" on PRs.
118116
# Because if the currently deployed `versions.json` on S3 is already broken,
119117
# then this job will fail, which would block us from merging a PR with fixes.

.gitignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22
cache/
33
node_modules/
44

5-
65
# Files:
76
internal.json
87
versions.json
8+
9+
# macOS-specific:
10+
.DS_Store

Makefile

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@
22
# make build
33
# make test
44

5+
ifdef CI
6+
JULIA ?= julia
7+
else
58
JULIA ?= julia +1.10
9+
endif
610

711
# This is the default target:
812
# It's a phony target because you might want to re-build versions.json even if none of the
@@ -47,6 +51,10 @@ nuke:
4751
$(RM) -v internal.json
4852
$(RM) -v versions.json
4953

54+
.PHONY: _purge_node_modules
55+
_purge_node_modules:
56+
$(RM) -r test/node/node_modules/
57+
5058
.PHONY: purge_download_cache_dir
5159
purge_download_cache_dir:
5260
$(RM) -r cache/

0 commit comments

Comments
 (0)