[release-1.6] Fix typeassert_tfunc for vararg PartialStructs#39402
Closed
martinholters wants to merge 1 commit into
Closed
[release-1.6] Fix typeassert_tfunc for vararg PartialStructs#39402martinholters wants to merge 1 commit into
typeassert_tfunc for vararg PartialStructs#39402martinholters wants to merge 1 commit into
Conversation
martinholters
commented
Jan 26, 2021
martinholters
added
bugfix
Member
Better against backport branch so the PkgEval that runs there will take it up. |
martinholters
changed the base branch from
release-1.6
to
backports-release-1.6
Member
Author
|
...where of course, this has conflicts... will rebase and resolve. |
martinholters
force-pushed
the
mh/fix_38971
branch
from
02cdde9 to
1abcc74
Compare
martinholters
force-pushed
the
mh/fix_38971
branch
from
1abcc74 to
5c5e255
Compare
Member
|
We should probably update master first with the new logic |
Member
Author
Yes, having slept this over, I agree. I'll push the pure bugfix (small excerpt from #38136) to the backports branch and open a new PR against master with the logic that enhances (restores) precision. |
Member
Author
|
The bugfix is on the release branch now and the precision improvement needs some more thinking through of corner cases. I'll open a PR against master once (and if) I get that sorted out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38971.
Alternatively, we could just backport the relevant part of #38136, but that would loose some precision for the non-const part compared to 1.5 (inferring as a vararg tuple even tough the type that as being asserted to is non-vararg), while this patch maintains it.
Note: PR against backports-release-1.6.
release-1.6. Or should this be against the backports branch?