Add user-defined near null space to aggregation-based AMG#117
Closed
Abdelrahman912 wants to merge 14 commits intoJuliaLinearAlgebra:masterfrom
Closed
Add user-defined near null space to aggregation-based AMG#117Abdelrahman912 wants to merge 14 commits intoJuliaLinearAlgebra:masterfrom
Abdelrahman912 wants to merge 14 commits intoJuliaLinearAlgebra:masterfrom
Conversation
User defined near null space for SA-AMG
termi-official
changed the title
Collaborator
|
Can you undo the format step? And can you also fix the failing test? |
| import AlgebraicMultigrid as AMG | ||
| using Test | ||
| using SparseArrays, LinearAlgebra | ||
| using Ferrite, FerriteGmsh, SparseArrays |
Collaborator
There was a problem hiding this comment.
Instead of using Ferrite here, can you refactor the tests here?
- We can have a helper script to generate the system matrix and near nullspace. You can dump these into e.g. matrix-market format.
- The actual test then just loads these files, bypassing the full assembly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #80
@termi-official, could you please check if any tests are missing?