Fix Smoothed Aggregation corner cases and test#129
Merged
Conversation
Collaborator
Author
|
@ranjanan can you review this? The SA implementation was not following the paper and produced sub-optimal aggregates in more complex use-cases. I also found some corner cases which were not correctly handled. |
Collaborator
Author
|
@Abdelrahman912 if you haver some capacity, this also needs a review. |
termi-official
force-pushed
the
do/fix-aggregation
branch
from
047550c to
ebf23f2
Compare
Collaborator
Author
|
Bump @Abdelrahman912 |
Abdelrahman912
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.