ci: workflow hygiene (concurrency, timeouts, loongarch fold, mips64, fork-safe codecov) (#346)

ViralBShah · claude · web-flow · commit a336ec337e38 · 2026-06-22T18:37:07.000-04:00
* ci: workflow hygiene pass Bundles a few low-risk improvements: - Fold cross-loongarch64.yml into cross.yml; loongarch64 needs the versioned gcc-14 package and per-entry CC/AR overrides, expressed via optional matrix fields with `||` fallbacks. - Add concurrency groups so superseded runs auto-cancel. - Add timeout-minutes: 10 to all jobs so a hung qemu/MSYS2 step fails fast instead of consuming the 6h default. - Bump actions/checkout to v7 (only breaking change is fork PR blocking in pull_request_target/workflow_run, neither used here). - Standardize parallelism: $(nproc) on Linux/MSYS2, $(getconf _NPROCESSORS_ONLN) on macOS (no `nproc` by default). - cross.yml runs `make test` under qemu-user-binfmt with QEMU_LD_PREFIX + LD_LIBRARY_PATH so new tests added to the Makefile target are picked up without editing the workflow. - Uncomment mips64/mips64el (per maintainer request) to surface whatever fails under newer qemu. - Guard the Codecov upload so it's skipped on forked-PR runs where the token isn't exposed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci: disable mips64 / mips64el cross jobs (see #347) Failures are spurious FPU exception flags under qemu-user on Ubuntu 24.04 — computed values are correct, only the post-call "Divide by zero" / "Invalid operation" flag state disagrees. 32-bit mips/mipsel pass cleanly under the same setup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci: re-enable mips64 / mips64el on ubuntu-26.04 Ubuntu 26.04 ships qemu 10.2.1 (vs 8.2 on 24.04). The MIPS64 n64 FPU flag handling that surfaced as spurious "Divide by zero" / "Invalid operation" failures on 24.04 should be fixed in qemu 10.x. Per-entry runs-on override keeps the rest of the matrix on 24.04. Refs #347. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci: re-disable mips64 / mips64el (toolchain dropped from 26.04) Bumping the runner to ubuntu-26.04 to get qemu 10.x doesn't work: Ubuntu 26.04 dropped gcc-mips64-linux-gnuabi64 entirely (Debian's broader MIPS deprecation). 24.04 has the toolchain but the qemu 8.2 FPU flag bug; 26.04 has new qemu but no cross-gcc. Refs #347. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,9 +7,15 @@ on:
     branches:
       - master
     tags: '*'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   test-unix:
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 10
     strategy:
       fail-fast: false
       matrix:
@@ -19,11 +25,12 @@ jobs:
           - macos-latest
           - macos-15-intel
     steps:
-      - uses: actions/checkout@v6
-      - run: make
+      - uses: actions/checkout@v7
+      - run: make -j$(getconf _NPROCESSORS_ONLN)
       - run: make test
   windows:
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 10
     strategy:
       fail-fast: false
       matrix:
@@ -37,38 +44,41 @@ jobs:
       run:
         shell: msys2 {0}
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v7
       - name: Set up the desired MSYS2 environment
         uses: msys2/setup-msys2@v2
         with:
           msystem: ${{matrix.sys}}
           install: base-devel mingw-w64-${{matrix.env}}-toolchain
-      - run: make
+      - run: make -j$(nproc)
       - run: make test
   code-coverage:
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     steps:
       - name: Checkout Openlibm
-        uses: actions/checkout@v6 
+        uses: actions/checkout@v7
       - name: Checkout Openlibm-test
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
         with:
           repository: 'JuliaMath/openlibm-test'
           path: 'openlibm-test'
       - name: Setup LCOV
         uses: hrishikesh-kadam/setup-lcov@v1
       - name: Build Openlibm
-        run: make -j`nproc` CODE_COVERAGE=1
+        run: make -j$(nproc) CODE_COVERAGE=1
       - name: Run Test
         run: |
-          make -j`nproc` -C openlibm-test \
+          make -j$(nproc) -C openlibm-test \
             USE_OPENLIBM=1 OPENLIBM_HOME="$(pwd)" \
-            SKIP_FP_EXCEPT_TEST=1 \
+            SKIP_FP_EXCEPT_TEST=1
       - name: Show Test Result
         run: cat openlibm-test/src/REPORT
       - name: Gen Coverage Report
         run: make gen-cov-report
       - name: Upload coverage to Codecov
+        # Codecov token isn't exposed to forked-PR runs; skip the upload there.
+        if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
         uses: codecov/codecov-action@v6
         with:
           files: ./cov-html/libopenlibm.info
diff --git a/.github/workflows/cross-loongarch64.yml b/.github/workflows/cross-loongarch64.yml
diff --git a/.github/workflows/cross.yml b/.github/workflows/cross.yml
@@ -9,45 +9,57 @@ on:
       - master
     tags: '*'
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   build-cross-qemu:
-    # TODO: We need Ubuntu 24.04 to use newer version of qemu,
-    #   switch to ubuntu-latest when `ubuntu-latest >= 24.04`
     runs-on: ubuntu-24.04
+    timeout-minutes: 10
     name: build-cross-qemu-${{ matrix.config.arch }}
     strategy:
       fail-fast: false
       matrix:
         config:
-          - { arch: arm,      triple: arm-linux-gnueabihf }
-          - { arch: aarch64,  triple: aarch64-linux-gnu }
-          - { arch: ppc,      triple: powerpc-linux-gnu }
-          - { arch: ppc64,    triple: powerpc64-linux-gnu }
-          - { arch: ppc64le,  triple: powerpc64le-linux-gnu }
-          - { arch: mips,     triple: mips-linux-gnu }
-          - { arch: mipsel,   triple: mipsel-linux-gnu }
-          # Builds successfully, but tests fail.
-          # - { arch: mips64,   triple: mips64-linux-gnuabi64 }
-          # - { arch: mips64el, triple: mips64el-linux-gnuabi64 }
-          - { arch: riscv64,  triple: riscv64-linux-gnu }
-          - { arch: s390x,    triple: s390x-linux-gnu }
+          - { arch: arm,         triple: arm-linux-gnueabihf }
+          - { arch: aarch64,     triple: aarch64-linux-gnu }
+          - { arch: ppc,         triple: powerpc-linux-gnu }
+          - { arch: ppc64,       triple: powerpc64-linux-gnu }
+          - { arch: ppc64le,     triple: powerpc64le-linux-gnu }
+          - { arch: mips,        triple: mips-linux-gnu }
+          - { arch: mipsel,      triple: mipsel-linux-gnu }
+          # mips64 / mips64el disabled. Tests fail under Ubuntu 24.04's
+          # qemu 8.2 (spurious FPU exception flags); Ubuntu 26.04 has
+          # newer qemu but dropped the mips64 cross-toolchain entirely.
+          # See #347.
+          # - { arch: mips64,    triple: mips64-linux-gnuabi64 }
+          # - { arch: mips64el,  triple: mips64el-linux-gnuabi64 }
+          - { arch: riscv64,     triple: riscv64-linux-gnu }
+          - { arch: s390x,       triple: s390x-linux-gnu }
+          # loongarch64 has no unversioned apt package; pin to gcc-14.
+          - { arch: loongarch64, triple: loongarch64-linux-gnu,
+              gcc_pkg: gcc-14-loongarch64-linux-gnu,
+              cc: loongarch64-linux-gnu-gcc-14,
+              ar: loongarch64-linux-gnu-gcc-ar-14 }
     env:
       ARCH: ${{ matrix.config.arch }}
       TRIPLE: ${{ matrix.config.triple }}
+      CC: ${{ matrix.config.cc }}
+      AR: ${{ matrix.config.ar }}
     steps:
-      - uses: actions/checkout@v6
-      - name: Install qemu and toolchain gcc-${{ matrix.config.triple }}
+      - uses: actions/checkout@v7
+      - name: Install qemu and toolchain
         run: |
           sudo apt update
-          sudo apt install qemu-user qemu-user-binfmt gcc-$TRIPLE -y
+          sudo apt install -y qemu-user qemu-user-binfmt \
+            ${{ matrix.config.gcc_pkg || format('gcc-{0}', matrix.config.triple) }}
       - name: Build with ${{ matrix.config.triple }}-gcc
-        run: make ARCH=$ARCH TOOLPREFIX=$TRIPLE-
+        run: make -j$(nproc) ARCH=$ARCH TOOLPREFIX=$TRIPLE- ${CC:+CC=$CC} ${AR:+AR=$AR}
       - name: Build tests
-        run: make -C test ARCH=$ARCH TOOLPREFIX=$TRIPLE-
-      - name: Run Tests
+        run: make -j$(nproc) -C test ARCH=$ARCH TOOLPREFIX=$TRIPLE- ${CC:+CC=$CC} ${AR:+AR=$AR}
+      - name: Run tests under qemu
         env:
-          QEMU_EXEC: qemu-${{ matrix.config.arch }}
-          CROSS_LIB: /usr/${{ matrix.config.triple }}
-        run: |
-          $QEMU_EXEC -L . -L $CROSS_LIB/  test/test-float
-          $QEMU_EXEC -L . -L $CROSS_LIB/  test/test-double
+          QEMU_LD_PREFIX: /usr/${{ matrix.config.triple }}
+          LD_LIBRARY_PATH: .
+        run: make test
