Download pseudos and make artifacts on-the-fly in make_artifacts.jl#16
Download pseudos and make artifacts on-the-fly in make_artifacts.jl#16azadoks wants to merge 3 commits intoJuliaMolSim:masterfrom
Conversation
|
Sorry this commit is so huge (due to all the removed files) that I'm unable to see what you actually did. Would you point me to the relevant changes (with best direct links to lines in the files in your fork. Github understandably has issues if you remove 12M lines of code in one commit). Given the above, take what I write with a grain of salt: I see your point about storage, but to me it has a clear benefit to have a "locked-in" version in a repo like this. In some of the parsing we do quite a lot (and take decisions) that should be reproducible. If all this happens in a CI run automagically, it gets very hard to figure out what went wrong if all of a sudden you get a different number when seemingly using the same pseudos. So broken magic here has potentially a huge impact on scientific outcome requiring some care and in my opinion therefore a human in the loop. My main concern is your 1.. Given the state of the pseudo ecosystem I think it is very likely, close to 100%, that a repo will just disappear in the future. We definitely need resilience towards that. Is storage such a big issue ? Can this not be solved by using multiple git subrepos that we control ? |
|
I guess storage is not the main issue for me per se but rather the pain of dealing with a repo with so many large files. I definitely agree that we should guard ourselves against repos disappearing (see, e.g. old versions of the full GBRV table). In this case maybe the best response is, as you say, subrepos. |
This is kind of hacky but works!
I've broken the fixed Dojo v0.5.
I'll work on fixing it by hosting only the modified pseudos in the repo and writing a builder function in
add_psedodojo.jl.I see two benefits to doing it this way:
And a few drawbacks:
add_*.jlconvention and the cli provided by the scriptsadd_*.jlscripts via the shell; requires precompilation each timeRelease sizes are still capped to the Git LFS limit, but that would have been a problem in any case.