[aws_c_http_jq] Add aws_c_http_jq fork of aws_c_http recipe#10707
Merged
Conversation
Member
|
I'm in principle ok with this, my concern is only on whether it's sustainable for you to maintain a fork of a project you aren't (I presume?) exceedingly familiar with but only an end user |
Contributor
Author
|
I'm no unconfident I could maintain the fork; I've already fixed a fairly critical memory bug and made a non-trivial contribution on my fork to provide server-side support for websockets. I'm fairly familiar with a lot of the code, but C isn't my strongest language, so it's certainly more effort to make changes there. I anticipate most of the effort required will be bringing in upstream fixes/changes and the occasional HTTP.jl-required change, both of which I feel comfortable with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have functionality implemented in a fork of aws-c-http that is stalled upstream. The maintainers haven't given a strong signal that they'll even be open to accepting the functionality or continue to maintain the overall server-side support, so I'm proactively forking the library with the idea that one of two scenarios plays out:
Release-wise, I'm proposing to start at the 0.9.3 release, which is the latest aws-c-http release, but that also includes my forked contribution. In that way, we could maintain compatibility with upstream releases when they come. If new forked contributions were needed, we could possibly wait until a new upstream release was made, or do an immediate release and maintain an N+M release schedule where this fork would always be M versions (# of fork-only releases) ahead of hte upstream version (N).
I'm open to concerns about this approach and willing to discuss. I'm also just trying to unblock the new HTTP.jl internals-rewrite I've been working on for a while and want to make some progress moving forward. It needs this forked functionality I worked on in an officially published binary, and trying to swap out the existing aws-c-http binary recipe with my fork would seem to have its own set of concerns.