Correct some Mat functions #227
Merged
Merged
Conversation
boriskaus
approved these changes
Feb 23, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess that is problably a known issue but lots of functions in the autowrapped part are calling
VecGetLocalSize(petsclib, x)even when there is noxin the function and that it is a matrix and not a vector used. But lots of them we don't care and probably never will so that is fine.I needed some functions from the Mat_wrappers.jl part, so I corrected the ones I needed (and some more) and added some tests for them.
Also got some help from Claude along the way.