Fix type instability and ghost-index bugs in DMStag corner/index helpers#244
Open
filoferra wants to merge 3 commits into
Open
Fix type instability and ghost-index bugs in DMStag corner/index helpers#244filoferra wants to merge 3 commits into
filoferra wants to merge 3 commits into
Conversation
getcorners_dmstag/getghostcorners_dmstag built intermediate Vectors and splatted them into CartesianIndex(...), making the return type non-concrete and boxing every downstream loop.
Old name kept as Base.@deprecate alias, and add global_indices_dmstag for the equivalent non-ghosted indices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes non-concrete return types (and the allocations that come with them) in DMStag's corner/index helpers.
Benchmarked on a 20x21 DMStag (ghosted boundaries, stencil width 2, single rank) via @allocated, Base.return_types, and @inferred.
getcorners_dmstaggetghostcorners_dmstaglocal_indices_dmstagRenamed DMStagGetIndices to local_indices_dmstag (old name kept as Base.@deprecate alias) for julia convention