Skip to content

Commit daa709e

Browse files
committed
Fix some JET warning regarding matching methods for strip(...) and parse(...)
``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:210 │ no matching method found `parse(::Type{Int64}, ::Nothing)` (1/2 union split): SlurmClusterManager.parse(SlurmClusterManager.Int, (m::RegexMatch{String})[1]::Union{Nothing, SubString{String}}) └──────────────────── ``` ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:210 │ no matching method found `parse(::Type{Int64}, ::Nothing)` (1/2 union split): SlurmClusterManager.parse(SlurmClusterManager.Int, (m::RegexMatch{String})[1]::Union{Nothing, SubString{String}})::Int64 └──────────────────── ``` ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:211 │ no matching method found `strip(::Nothing)` (1/2 union split): SlurmClusterManager.strip((m::RegexMatch{String})[2]::Union{Nothing, SubString{String}}) └──────────────────── ``` ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:211 │ no matching method found `strip(::Nothing)` (1/2 union split): SlurmClusterManager.strip((m::RegexMatch{String})[2]::Union{Nothing, SubString{String}})::SubString{String} └──────────────────── ``` (cherry picked from commit 79b9476)
1 parent 0120dba commit daa709e

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

src/slurmmanager.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,10 +205,12 @@ function Distributed.launch(manager::SlurmManager, params::Dict, instances_arr::
205205
line = readline(manager.srun_proc)
206206
m = match(r".*:(\d*)#(.*)", line)
207207
m === nothing && error("could not parse $line")
208+
m[1] === nothing && error("could not extract port (m[1]) after parsing $line")
209+
m[2] === nothing && error("could not extract host (m[2]) after parsing $line")
208210

209211
config = WorkerConfig()
210-
config.port = parse(Int, m[1])
211-
config.host = strip(m[2])
212+
config.port = parse(Int, m[1]::AbstractString)
213+
config.host = strip(m[2]::AbstractString)
212214

213215
@debug "Worker $i ready on host $(config.host), port $(config.port)"
214216

0 commit comments

Comments
 (0)