Refactor the SLURM_NTASKS and SLURM_JOB_ID functionality out into separate utility functions, and add some more unit tests to increase code coverage#44
Closed
DilumAluthge wants to merge 2 commits into
Closed
Conversation
1 task
DilumAluthge
force-pushed
the
dpa/ntasks
branch
from
8f02cca to
938306b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 89.36% 94.11% +4.75%
==========================================
Files 2 2
Lines 94 102 +8
==========================================
+ Hits 84 96 +12
+ Misses 10 6 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Code coverage on Code coverage on this PR is 93%. |
DilumAluthge
force-pushed
the
dpa/ntasks
branch
from
ae30922 to
74bf0e8
Compare
DilumAluthge
force-pushed
the
dpa/code-coverage-2
branch
from
3189117 to
410734b
Compare
DilumAluthge
force-pushed
the
dpa/ntasks
branch
from
74bf0e8 to
03df383
Compare
… separate utility functions, and add some more unit tests to increase code coverage
DilumAluthge
force-pushed
the
dpa/ntasks
branch
from
03df383 to
7692b64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: