Draft: Stub for coincident intersection#55
Open
TacHawkes wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 73.46% 72.68% -0.78%
==========================================
Files 61 61
Lines 3885 3888 +3
==========================================
- Hits 2854 2826 -28
- Misses 1031 1062 +31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the coincident intersection resolution scheme we discussed, assuming up to three coincident objects can be returned by the trace functions within a distance threshold. In this "tie-breaker" logic, I handle sandwiched coatings (currently only the
ThinBeamsplitter) and touching volumetric shapes (such as cemented doublet lenses). These coincident elements are then stored directly in theIntersectionobject context. This allows specializedinteract3dmethods to query adjacent exiting/entering components and tailor custom refraction or reflection behavior without needing global lookups.At least as of now, this merge request actually almost removes more code than it adds to BMO as we can now get rid of some "stupid" methods. The number of lines is just more at the moment, because my VSCode auto-reformatted some code.